]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
authPrompt: Use signal handler instead of vfunc
authorFlorian Müllner <fmuellner@gnome.org>
Tue, 14 May 2024 17:49:56 +0000 (19:49 +0200)
committerMarge Bot <marge-bot@gnome.org>
Wed, 22 May 2024 10:11:00 +0000 (10:11 +0000)
The prompt itself may get destroyed when canceled, in which
case it is no longer possible to chain up in the vfunc.

This is usually not an issue as the prompt is only destroyed
at the end of a transition, but it results in a warning if
animations are disabled.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3317>

js/gdm/authPrompt.js

index ec1c931e6315ea1fa9f913d8edf79719921c35c4..ece597cc31e45761d70a21f49ada2a3ddb085879 100644 (file)
@@ -133,10 +133,10 @@ export const AuthPrompt = GObject.registerClass({
         this._userVerifier = null;
     }
 
-    vfunc_key_press_event(event) {
+    on_key_press_event(event) {
         if (event.get_key_symbol() === Clutter.KEY_Escape)
             this.cancel();
-        return super.vfunc_key_press_event(event);
+        return Clutter.EVENT_PROPAGATE;
     }
 
     _initInputRow() {